Skip to content

aligning workflow source proto with storage service#285

Merged
patrickhuie19 merged 3 commits into
mainfrom
chore/workflow-source-alignment
Feb 5, 2026
Merged

aligning workflow source proto with storage service#285
patrickhuie19 merged 3 commits into
mainfrom
chore/workflow-source-alignment

Conversation

@patrickhuie19
Copy link
Copy Markdown
Contributor

@patrickhuie19 patrickhuie19 commented Feb 5, 2026 •
edited
Loading

Splitting the difference.

@patrickhuie19 patrickhuie19 requested review from a team as code owners February 5, 2026 01:54
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: f36cee6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

👋 patrickhuie19, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedFeb 5, 2026, 11:12 PM

shileiwill
shileiwill reviewed Feb 5, 2026
View reviewed changes
Comment thread workflows/sources/v1/workflow_metadata_source.proto
string don_family = 10;
// managed_by is the origin of this workflow (CLI, CREC, etc.)
WorkflowManagedBy managed_by = 11;
string organization_id = 12;
Copy link
Copy Markdown

@shileiwill shileiwill Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the order to match here?

shileiwill
shileiwill approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown

@shileiwill shileiwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed with Patrick that the order doesnt matter since the generated types dont care about the order of fields.

@patrickhuie19 patrickhuie19 enabled auto-merge (squash) February 5, 2026 22:47
@patrickhuie19 patrickhuie19 merged commit 3b9c600 into main Feb 5, 2026
21 checks passed
@patrickhuie19 patrickhuie19 deleted the chore/workflow-source-alignment branch February 5, 2026 23:13
This was referenced Feb 6, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@shileiwill shileiwill shileiwill approved these changes

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

@krehermann krehermann Awaiting requested review from krehermann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@patrickhuie19 @vyzaldysanchez @shileiwill